refactor(amazonq): move getIndentedCode to textDocumentUtilities and use cwsprChatInteractionType #5765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required. |
ivikash
force-pushed
the
fix/view-diff
branch
from
1436062 to
d8d06f6
Compare
ivikash
changed the title
| * Indents the given code based on the current document's indentation at the selection start. | ||
| * | ||
| * @param {any} message - The message object containing the code. | ||
| * @param {vscode.TextDocument} doc - The VSCode document where the code is applied. |
Contributor
There was a problem hiding this comment.
non-blocker: This will make the value actually clickable in vscode when you hover the docstring and also if TextDocument were to be renamed this would automatically update. Note you need to add a string in between "param" and the {} or it doesnt render properly
Suggested change
| * @param {vscode.TextDocument} doc - The VSCode document where the code is applied. | |
| * @param - {@link vscode.TextDocument} doc - The VSCode document where the code is applied. |
nkomonen-amazon
approved these changes
Oct 10, 2024
ivikash
force-pushed
the
fix/view-diff
branch
from
d8d06f6 to
ff5f135
Compare
justinmk3
reviewed
Oct 10, 2024
…use cwsprChatInteractionType from aws-toolkit-common
ivikash
force-pushed
the
fix/view-diff
branch
from
ff5f135 to
6680f0b
Compare
tverney
pushed a commit
to tverney/aws-toolkit-vscode
that referenced
this pull request
Oct 21, 2024
- move getIndentedCode to textDocumentUtilities - use cwsprChatInteractionType from aws-toolkit-common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move getIndentedCode to textDocumentUtilities and use cwsprChatInteractionType from aws-toolkit-common
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.